Re: [PATCH v2] phy: cadence: Sierra: Add single link SGMII register configuration

[Uwe Kleine-König]

Hello,

On Mon, May 08, 2023 at 04:01:40PM +0000, Marcin Wierzbicki wrote:
> Add single link SGMII register configuration for no SSC for
> cdns,sierra-phy-t0 compatibility string.
> The configuration is based on Sierra Programmer's Guide and
> validated in Cisco CrayAR SoC.
> 
> Co-developed-by: Bartosz Wawrzyniak <bwawrzyn@xxxxxxxxx>
> Signed-off-by: Bartosz Wawrzyniak <bwawrzyn@xxxxxxxxx>
> Signed-off-by: Marcin Wierzbicki <mawierzb@xxxxxxxxx>
> Change-Id: Id4c093a1bbf409f3176736b5326854a1396391c1

The Change-Id footers are not supposed to appear in the kernel's
history, so it's better to leave them out when submitting a patch.

(I didn't look at the remaining patch, so me not criticizing more
doesn't implicitly mean the rest is fine. (But of course it also doesn't
mean it is not fine.))

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature