Re: [PATCH 2/2] PCI: rcar-host: add support for optional regulators

[Wolfram Sang]

> > +       int i, err;
> 
> unsigned int i?

OK.

> 
> >         struct pci_host_bridge *bridge;
> 
> The (lack of) reverse-Xmas-tree ordering is hurting my OCD, but that's
> not your fault...

Ack :) I can change it, though.

> > +                       dev_err_probe(dev, err, "error enabling regulator %s\n",
> > +                                     rcar_pcie_supplies[i]);
> 
> Shouldn't this return, and propagate the error code upstream?

Ouch, brown paper bag, please.

Attachment: signature.asc
Description: PGP signature