Re: [PATCH v3 3/6] serial: 8250: Add dl_read/write, bugs and mapsize into plat_serial8250_port

[Jiri Slaby]

On 09. 05. 23, 13:39, Ilpo Järvinen wrote:
> Add mapsize, bugs, and divisor latch read/write functions
> (->dl_read/write()) into plat_serial8250_port to carry the setup
> necessary for RT288x/Au1xxx devices over to uart port.
>
> Document the added members with kerneldoc style but do not enable
> kerneldoc yet as there are many fields which remain undocumented.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

> --- a/include/linux/serial_8250.h
> +++ b/include/linux/serial_8250.h
...
> @@ -28,8 +44,11 @@ struct plat_serial8250_port {
>   	unsigned char	has_sysrq;	/* supports magic SysRq */
>   	unsigned int	type;		/* If UPF_FIXED_TYPE */
>   	upf_t		flags;		/* UPF_* flags */
> +	unsigned short	bugs;		/* port bugs */

I would suggest u16 for bitfields like this. (Or DECLARE_BITMAP, but 
that would unnecessarily eat a long.)

thanks,
--
js
suse labs