Re: [PATCH 6.1 000/610] 6.1.28-rc2 review

[Conor Dooley]

On Tue, May 09, 2023 at 02:18:35PM -0700, Guenter Roeck wrote:
> On Tue, May 09, 2023 at 09:41:42PM +0100, Conor Dooley wrote:
> > On Tue, May 09, 2023 at 12:57:58PM -0700, Guenter Roeck wrote:
> > > On Tue, May 09, 2023 at 05:26:31AM +0200, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 6.1.28 release.
> > > > There are 610 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Thu, 11 May 2023 03:05:05 +0000.
> > > > Anything received after that time might be too late.
> > > > 
> > > 
> > > Build results:
> > > 	total: 155 pass: 155 fail: 0
> > > Qemu test results:
> > > 	total: 519 pass: 519 fail: 0
> > > 
> > > New persistent runtime warning when booting riscv32/64 images:
> > 
> > You sure this is new? I seem to be able to reproduce for QEMU (which I
> 
> New for my tests, yes.
> 
> > don't usually test) in several versions of 6.1. Don't see it in (my)
> > hardware though, as the particular platform doesn't end up calling the
> > offending function. Out of curiosity, what's your QEMU invocation?
> 
> Example boot from initrd:
> 
> qemu-system-riscv64 -M virt -m 512M \
>      -no-reboot -kernel arch/riscv/boot/Image \
>      -initrd rootfs.cpio \
>      -device e1000,netdev=net0 \
>      -netdev user,id=net0 -bios default \
>      -append "panic=-1 rdinit=/sbin/init console=ttyS0,115200 earlycon=uart8250,mmio,0x10000000,115200" \
>      -nographic -monitor none

Cool, was mainly interested in seeing if you were explicitly enabling
any ISA extensions. NGL, I expected to see some.

> qemu version is 8.0, but I don't think that makes a difference.

I'm on 7.2.50 (v7.2.0-2653-g7080c3ab79-dirty) as it is where I ended
during my last bisection of QEMU. But aye, makes no odds - I see it on a
more recent 8.0.50 version too.

> What does your command line look like ?

In this particular instance:
	qemu-system-riscv64 -M virt \
		-m 2G -smp 5 \
		-nographic \
		-kernel $(vmlinux_bin) \
		-initrd $(initramfs)

> > Anyways, looks like a partial backport is the cause. How's it look with:

> This fixes the problem for me.

Cool, shall send it as a real patch. Thanks.

Attachment: signature.asc
Description: PGP signature