Re: [PATCH v4 01/15] dmaengine: idxd: add wq driver name support for accel-config user tool

[Tom Zanussi]

On Tue, 2023-05-09 at 10:48 -0700, Fenghua Yu wrote:
> Hi, Tom,
> 
> On 5/8/23 13:07, Tom Zanussi wrote:
> > From: Dave Jiang <dave.jiang@xxxxxxxxx>
> > 
> > With the possibility of multiple wq drivers that can be bound to
> > the wq,
> > the user config tool accel-config needs a way to know which wq
> > driver to
> > bind to the wq. Introduce per wq driver_name sysfs attribute where
> > the user
> > can indicate the driver to be bound to the wq. This allows accel-
> > config to
> > just bind to the driver using wq->driver_name.
> > 
> > Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> > Signed-off-by: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>
> > ---
> >   .../ABI/stable/sysfs-driver-dma-idxd          |  6 ++++
> >   drivers/dma/idxd/cdev.c                       |  8 ++++++
> >   drivers/dma/idxd/dma.c                        |  6 ++++
> >   drivers/dma/idxd/idxd.h                       |  9 ++++++
> >   drivers/dma/idxd/sysfs.c                      | 28
> > +++++++++++++++++++
> >   include/uapi/linux/idxd.h                     |  1 +
> >   6 files changed, 58 insertions(+)
> > 
> > diff --git a/Documentation/ABI/stable/sysfs-driver-dma-idxd
> > b/Documentation/ABI/stable/sysfs-driver-dma-idxd
> > index 3becc9a82bdf..d5daae442fe7 100644
> > --- a/Documentation/ABI/stable/sysfs-driver-dma-idxd
> > +++ b/Documentation/ABI/stable/sysfs-driver-dma-idxd
> > @@ -244,6 +244,12 @@ Description:       Shows the operation
> > capability bits displayed in bitmap format
> >                 correlates to the operations allowed. It's visible
> > only
> >                 on platforms that support the capability.
> >   
> > +What:          /sys/bus/dsa/devices/wq<m>.<n>/driver_name
> > +Date:          Mar 27, 2023 > +KernelVersion:  6.4.0
> 
> Need to be changed to 6.5.0 now:)

Yes, will change.

> 
> After fixing the KernelVersion,
> 
> Reviewed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> 

Thanks for your review(s).

Tom

> Thanks.
> 
> -Fenghua