RE: [PATCH 2/2] ufs: don't use the fair tag sharings

From: Avri Altman
Date: Tue May 09 2023 - 12:20:01 EST


> On 5/9/23 01:03, Avri Altman wrote:
> > However, I think the decision of that should be of the platform owner,
> > And not in the core driver.
>
> Hi Avri,
>
> I don't see any use case in which performance of a UFS device would be
> improved
> by leaving QUEUE_FLAG_FAIR_TAG_SHARING enabled. Are you perhaps aware
> of such a
> use case?
Following your argument, then why fair allocation exists in the first place?

When running benchmarks I am hacking the scheduler's "fair" tag allocation as well.
That's why I acked this change.

Since this change may affect the IO profile as a whole,
I think the platform owners should have the flexibility not to use it,
Should they choose to.

Thanks,
Avri
>
> Thanks,
>
> Bart.