Re: [patch v3 14/36] [patch V2 14/38] cpu/hotplug: Rework sparse_irq locking in bringup_cpu()

From: Peter Zijlstra
Date: Tue May 09 2023 - 07:04:27 EST

Next message: Frederic Weisbecker: "Re: [patch 06/20] posix-timers: Annotate concurrent access to k_itimer::it_signal"
Previous message: Aidan MacDonald: "[PATCH v1 6/6] regmap-irq: Drop backward compatibility for inverted mask/unmask"
In reply to: Thomas Gleixner: "[patch v3 14/36] [patch V2 14/38] cpu/hotplug: Rework sparse_irq locking in bringup_cpu()"
Next in thread: Thomas Gleixner: "Re: [patch v3 14/36] [patch V2 14/38] cpu/hotplug: Rework sparse_irq locking in bringup_cpu()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, May 08, 2023 at 09:43:49PM +0200, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
> There is no harm to hold sparse_irq lock until the upcoming CPU completes
> in cpuhp_online_idle(). This allows to remove cpu_online() synchronization
> from architecture code.

Uuuuuhh.. damn. Can you at the very least ammend the comment near
irq_lock_sparse() to mention these extra duties?

Next message: Frederic Weisbecker: "Re: [patch 06/20] posix-timers: Annotate concurrent access to k_itimer::it_signal"
Previous message: Aidan MacDonald: "[PATCH v1 6/6] regmap-irq: Drop backward compatibility for inverted mask/unmask"
In reply to: Thomas Gleixner: "[patch v3 14/36] [patch V2 14/38] cpu/hotplug: Rework sparse_irq locking in bringup_cpu()"
Next in thread: Thomas Gleixner: "Re: [patch v3 14/36] [patch V2 14/38] cpu/hotplug: Rework sparse_irq locking in bringup_cpu()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]