Re: [patch v3 33/36] x86/apic: Save the APIC virtual base address

From: Sergey Shtylyov
Date: Tue May 09 2023 - 05:20:52 EST


Hello!

On 5/8/23 10:44 PM, Thomas Gleixner wrote:

> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
> For parallel CPU brinugp it's required to read the APIC ID in the low level
> startup code. The virtual APIC base address is a constant because its a
> fix-mapped address. Exposing that constant which is composed via macros to
> assembly code is non-trivial dues to header inclusion hell.

s/dues/due/?

> Aside of that it's constant only because of the vsyscall ABI
> requirement. Once vsyscall is out of the picture the fixmap can be placed
> at runtime.
>
> Avoid header hell, stay flexible and store the address in a variable which
> can be exposed to the low level startup code.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Tested-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>

[...]

MBR, Sergey