RE: [EXT] Re: [PATCH 1/2 v7] dt-bindings: watchdog: marvell GTI system watchdog driver

[Bharat Bhushan]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Tuesday, May 9, 2023 1:38 PM
> To: Bharat Bhushan <bbhushan2@xxxxxxxxxxx>; wim@xxxxxxxxxxxxxxxxxx;
> linux@xxxxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> linux-watchdog@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>
> Subject: Re: [EXT] Re: [PATCH 1/2 v7] dt-bindings: watchdog: marvell GTI system
> watchdog driver
> 
> On 09/05/2023 09:26, Bharat Bhushan wrote:
> 
> 
> >>> +properties:
> >>> +  compatible:
> >>> +    oneOf:
> >>> +      - const: marvell,octeontx2-wdt
> >>
> >> Why is this alone? Judging by the enum below, octeontx2 is not specific.
> >>
> >>> +      - items:
> >>> +          - enum:
> >>> +              - marvell,octeontx2-95xx-wdt
> >>> +              - marvell,octeontx2-96xx-wdt
> >>> +              - marvell,octeontx2-98xx-wdt
> >>
> >> We don't allow wildcards in general
> >
> > Marvell have octeontx2 series of processor which have watchdog timer.
> > In 95xx,98xx,96xx are the processors in octeontx2 series of processor. So
> octeontx2-95xx is on soc, octeontx2-96xx is another and so on.
> 
> No, 95xx is not a processor. Otherwise please point me to exact product
> datasheet. Hint: I checked it.

Looks like 95xx data sheet is not public, will remove in that case.

> 
> >
> >>
> >>> +          - const: marvell,octeontx2-wdt
> >>> +      - const: marvell,cn10k-wdt
> >>
> >> Same question - why is this alone?
> > Same here, Marvell have cn10k series of processors and cn10kx and cnf10kx are
> the processor in this series.
> 
> I don't understand how does it explain my concern. This is alone because there
> are series of processors? How is that related?

Tried to make it look like other drivers. Let's keep it simple, we want to enable this only for below ones

properties:
  compatible:
    enum:
     - marvell,cn10k-wdt
     - marvell,octeontx2-wdt

Are you good with that?

Thanks
-Bharat

> 
> >
> > One of the difference between octeontx2 and cn10k series processor is
> number of timers available. Which within the available set of timers one of the
> timer is programmed to be watchdog timer.
> 
> Wrap your replies. It's difficult to read.
> 
> >
> > Can you please propose how you want these compatible to be defined?
> 
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__elixir.bootlin.com_linux_v6.4-
> 2Drc1_source_Documentation_devicetree_bindings_soc_qcom_qcom-
> 2Ceud.yaml-
> 23L19&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=PAAlWswPe7d8gHlGbCLmy
> 2YezyK7O3Hv_t2heGnouBw&m=sbDC9A17UO1l_M7xW5546TQhAMxoejy6M_sv
> PitOn_9sOxb0ru3H7X9eEW00Gqna&s=tQrCoVSHNEOd9CkEeu6leJbmP0rtbL5Vd
> WlE9GQ-GTI&e=
> 
> Best regards,
> Krzysztof