Re: [PATCH v4 5/8] power: supply: rt5033_charger: Add RT5033 charger device driver

[Jakob Hauser]

Hi Sebastian,

On 08.05.23 08:50, Sebastian Reichel wrote:
> Hi,
>
> On Sat, May 06, 2023 at 05:54:32PM +0200, Jakob Hauser wrote:
> > This patch adds device driver of Richtek RT5033 PMIC. The driver supports
> > switching charger. rt5033 charger provides three charging modes. The charging
> > modes are pre-charge mode, fast charge mode and constant voltage mode. They
> > vary in charge rate, the charge parameters can be controlled by i2c interface.
> >
> > Cc: Beomho Seo <beomho.seo@xxxxxxxxxxx>
> > Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> > Tested-by: Raymond Hackley <raymondhackley@xxxxxxxxxxxxxx>
> > Signed-off-by: Jakob Hauser <jahau@xxxxxxxxxxxxxx>
> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > ---
>
> Driver looks mostly good. I still found a couple of small things
> though. Please find them inline.

...

The change requests look reasonable. Thanks for additional hints. I'll 
implement them in v5.

Kind regards,
Jakob