Re: [PATCH v2] tools/nolibc: Fix build of stdio.h due to header ordering

From: Shuah Khan
Date: Mon May 08 2023 - 13:19:07 EST


On 5/8/23 07:30, Mark Brown wrote:
When we added fd based file streams we created references to STx_FILENO in
stdio.h but these constants are declared in unistd.h which is the last file
included by the top level nolibc.h meaning those constants are not defined
when we try to build stdio.h. This causes programs using nolibc.h to fail
to build.

Reorder the headers to avoid this issue.

Fixes: d449546c957f ("tools/nolibc: implement fd-based FILE streams")
Acked-by: Willy Tarreau <w@xxxxxx>
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
---

Applied now to linux-kselftest fixes for 6.4-rc2

thanks,
-- Shuah