Re: [PATCH 05/11] dt-bindings: clock: qcom: gcc-ipq9574: Add Q6 gcc clock control

[Manikanta Mylavarapu]

On 3/7/2023 8:49 PM, Krzysztof Kozlowski wrote:
> On 07/03/2023 05:41, Manikanta Mylavarapu wrote:
> > Add support for the QDSP6 gcc clock control used on IPQ9574
> > based devices. This would allow mpd remoteproc driver to control
> > the required gcc clocks to bring the subsystem out of reset.
> >
> > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
> > ---
> >   include/dt-bindings/clock/qcom,ipq9574-gcc.h | 159 ++++++++++---------
> >   1 file changed, 83 insertions(+), 76 deletions(-)
> >
> > diff --git a/include/dt-bindings/clock/qcom,ipq9574-gcc.h b/include/dt-bindings/clock/qcom,ipq9574-gcc.h
> > index c89e96d568c6..8bd6350ecd56 100644
> > --- a/include/dt-bindings/clock/qcom,ipq9574-gcc.h
> > +++ b/include/dt-bindings/clock/qcom,ipq9574-gcc.h
> > @@ -138,80 +138,87 @@
> >   #define WCSS_AHB_CLK_SRC				129
> >   #define GCC_Q6_AHB_CLK					130
> >   #define GCC_Q6_AHB_S_CLK				131
> > -#define GCC_WCSS_ECAHB_CLK				132
> > -#define GCC_WCSS_ACMT_CLK				133
>
> That's an ABI break, if file was accepted. Or a very weird change
> anyway, if it wasn't (why adding entry and immediately changing it?).
>
> Best regards,
> Krzysztof

I will add new macros at the end instead in middle.

Thanks & Regards,
Manikanta.