Re: [PATCH 1/4] serial: 8250: omap: Fix freeing of resources on failed register

From: Tony Lindgren
Date: Mon May 08 2023 - 07:08:50 EST


* Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> [230508 09:55]:
> An unrelated comment to the patch itself, there seems to be somewhat
> handwavy and possibly wrong calculation for the pm qos latency. First of
> all, I think it would want something based on port->frame_time, and I'm
> far from convinced that 64 is right as it matches FIFO size which doesn't
> feel correct for a wakeup related time.

Thanks for spotting it, good point. I'll take a look at that in a separate
patch.

Regards,

Tony