Re: [PATCH v2] dt-bindings: firmware: brcm,kona-smc: convert to YAML

[Stanislav Jakubek]

On Mon, May 08, 2023 at 11:23:52AM +0200, Krzysztof Kozlowski wrote:
> On 08/05/2023 10:10, Stanislav Jakubek wrote:
> > Convert Broadcom Kona family Secure Monitor bounce buffer bindings
> > to DT schema.
> > 
> > Changes during conversion:
> >   - move from misc to firmware subdirectory
> >   - add used, but previously undocumented SoC-specific compatibles
> >   - drop deprecated compatibles (they've been deprecated for ~10 years)
> > 
> > Signed-off-by: Stanislav Jakubek <stano.jakubek@xxxxxxxxx>
> > ---
> > 
> > Changes in V2:
> >   - move to firmware subdirectory (Krzysztof)
> >   - drop deprecated compatibles (Krzysztof)
> >   - adjusted commit message to reflect the above changes
> >   
> >  .../bindings/firmware/brcm,kona-smc.yaml      | 40 +++++++++++++++++++
> >  .../bindings/misc/brcm,kona-smc.txt           | 15 -------
> >  2 files changed, 40 insertions(+), 15 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/firmware/brcm,kona-smc.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/misc/brcm,kona-smc.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/firmware/brcm,kona-smc.yaml b/Documentation/devicetree/bindings/firmware/brcm,kona-smc.yaml
> > new file mode 100644
> > index 000000000000..16c7928a0daa
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/firmware/brcm,kona-smc.yaml
> > @@ -0,0 +1,40 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/firmware/brcm,kona-smc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Broadcom Kona family Secure Monitor bounce buffer
> > +
> > +description:
> > +  A bounce buffer used for non-secure to secure communications.
> > +
> > +maintainers:
> > +  - Florian Fainelli <f.fainelli@xxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> 
> You do not need oneOf.

Nice catch! Seems I forgot to remove it when removing the deprecated
compatibles. Will fix in V3.

Stanislav

> 
> 
> Best regards,
> Krzysztof
>