回复: [PATCH] cpufreq: create cooling device based on ACPI

From: Xinglong Yang
Date: Mon May 08 2023 - 03:13:45 EST


Does this patch need to be packaged with other patches?
Whether the function cpufreq_cooling_register is declared in cpufreq.c?

-----邮件原件-----
发件人: wangyouwan@xxxxxxx <wangyouwan@xxxxxxx>
发送时间: 2023年4月28日 15:03
收件人: rafael@xxxxxxxxxx; viresh.kumar@xxxxxxxxxx
抄送: linux-pm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; youwan Wang <wangyouwan@xxxxxxx>
主题: [PATCH] cpufreq: create cooling device based on ACPI

EXTERNAL EMAIL

From: youwan Wang <wangyouwan@xxxxxxx>

When using the "scpi_cpufreq" driver, an error
occurs:cpufreq_cooling: OF node not available for cpu*.
The current computer motherboard is using ACPI firmware.
Go to see that the error is caused by calling the "of_cpufreq_cooling_register" interface.
comment:create cpufreq cooling device based on DT.

Signed-off-by: youwan Wang <wangyouwan@xxxxxxx>
---
drivers/cpufreq/cpufreq.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 6b52ebe5a890..3418c68959d5 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1528,8 +1528,13 @@ static int cpufreq_online(unsigned int cpu)
if (cpufreq_driver->ready)
cpufreq_driver->ready(policy);

- if (cpufreq_thermal_control_enabled(cpufreq_driver))
+ if (cpufreq_thermal_control_enabled(cpufreq_driver)) { #ifdef
+CONFIG_ACPI
+ policy->cdev = cpufreq_cooling_register(policy); #else
policy->cdev = of_cpufreq_cooling_register(policy);
+#endif
+ }

pr_debug("initialization complete\n");

--
2.25.1



This email (including its attachments) is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. Unauthorized use, dissemination, distribution or copying of this email or the information herein or taking any action in reliance on the contents of this email or the information herein, by anyone other than the intended recipient, or an employee or agent responsible for delivering the message to the intended recipient, is strictly prohibited. If you are not the intended recipient, please do not read, copy, use or disclose any part of this e-mail to others. Please notify the sender immediately and permanently delete this e-mail and any attachments if you received it in error. Internet communications cannot be guaranteed to be timely, secure, error-free or virus-free. The sender does not accept liability for any errors or omissions.