Re: [PATCH v2 1/3] dt-bindings: thermal: tsens: Add ipq9574 compatible

From: Krzysztof Kozlowski
Date: Mon May 08 2023 - 02:28:47 EST


On 08/05/2023 07:32, Varadarajan Narayanan wrote:
> From: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
>
> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens.
>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>

Drop the ack, it's a bigger change.

> Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> ---
> [v2]:
> Thanks to Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> for the tip to make qcom,ipq8074-tsens as fallback.
> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index d1ec963..ea67cf9 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -64,8 +64,11 @@ properties:
> - const: qcom,tsens-v2
>
> - description: v2 of TSENS with combined interrupt
> - enum:
> - - qcom,ipq8074-tsens
> + - const: qcom,ipq8074-tsens
> + - items:
> + - enum:

Please test the patch after changes and before sending. Missing indent
which test would point out.

Best regards,
Krzysztof