Re: [RFC PATCH v2 2/3] virtio_pci: add a definition of queue flag in ISR

From: Jason Wang
Date: Mon May 08 2023 - 00:00:13 EST


On Thu, Apr 27, 2023 at 6:44 PM Shunsuke Mie <mie@xxxxxxxxxx> wrote:
>
> Already it has beed defined a config changed flag of ISR, but not the queue

Typo should be "been".

> flag. Add a macro for it.
>
> Signed-off-by: Shunsuke Mie <mie@xxxxxxxxxx>

Other than this,

Acked-by: Jason Wang <jasowang@xxxxxxxxxx>

> ---
> include/uapi/linux/virtio_pci.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h
> index f703afc7ad31..d405bea27240 100644
> --- a/include/uapi/linux/virtio_pci.h
> +++ b/include/uapi/linux/virtio_pci.h
> @@ -94,6 +94,9 @@
>
> #endif /* VIRTIO_PCI_NO_LEGACY */
>
> +/* Bits for ISR status field:only when if MSI-X is disabled */
> +/* The bit of the ISR which indicates a queue entry update. */
> +#define VIRTIO_PCI_ISR_QUEUE 0x1
> /* The bit of the ISR which indicates a device configuration change. */
> #define VIRTIO_PCI_ISR_CONFIG 0x2
> /* Vector value used to disable MSI for queue */
> --
> 2.25.1
>