Re: [PATCH blktests v3 01/12] nvme/rc: Auto convert test device size info

[Shinichiro Kawasaki]

On May 03, 2023 / 10:02, Daniel Wagner wrote:
[...]
> +convert_to_mb()
> +{
> +	local str=$1
> +	local res
> +
> +	res=$(echo "${str}" | sed -n 's/^\([0-9]\+\)$/\1/p')
> +	if [[ -n "${res}" ]]; then
> +		echo "$((res / 1024 / 1024))"
> +	fi
> +
> +	res=$(echo "${str}" | sed -n 's/^\([0-9]\+\)[mM]$/\1/p')
> +	if [[ -n "${res}" ]]; then
> +		echo "$((res))"
> +	fi
> +
> +	res=$(echo "${str}" | sed -n 's/^\([0-9]\+\)[gG]$/\1/p')
> +	if [[ -n "${res}" ]]; then
> +        	echo "$((res * 1024))"

Here are some spaces still  left.

> +	fi
> +}