Re: [PATCH] riscv: mm: use bitmap_zero() API

From: Anup Patel
Date: Sun May 07 2023 - 11:40:17 EST


On Sat, May 6, 2023 at 2:42 PM <ye.xingchen@xxxxxxxxxx> wrote:
>
> From: Ye Xingchen <ye.xingchen@xxxxxxxxxx>
>
> bitmap_zero() is faster than bitmap_clear(), so use bitmap_zero()
> instead of bitmap_clear().
>
> Signed-off-by: Ye Xingchen <ye.xingchen@xxxxxxxxxx>

Looks good to me.

Reviewed-by: Anup Patel <anup@xxxxxxxxxxxxxx>

Regards,
Anup

> ---
> arch/riscv/mm/context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c
> index 12e22e7330e7..217fd4de6134 100644
> --- a/arch/riscv/mm/context.c
> +++ b/arch/riscv/mm/context.c
> @@ -67,7 +67,7 @@ static void __flush_context(void)
> lockdep_assert_held(&context_lock);
>
> /* Update the list of reserved ASIDs and the ASID bitmap. */
> - bitmap_clear(context_asid_map, 0, num_asids);
> + bitmap_zero(context_asid_map, num_asids);
>
> /* Mark already active ASIDs as used */
> for_each_possible_cpu(i) {
> --
> 2.25.1