Re: [PATCH RESEND v3 0/5] iio: adc: qcom-spmi-vadc: Propagate fw node label to userspace

[Jonathan Cameron]

On Tue,  2 May 2023 01:17:32 +0200
Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> wrote:

> Implement read_label in qcom-spmi-vadc to see DT-specified label names
> in userspace.  At the same time clear up some documentation around
> extend_name to promote read_label, and normalize similar code in
> qcom-spmi-adc5.

Whole series looks good to me. I'd like some review from QCOM focused
folk though before I take it.

Thanks,

Jonathan

> 
> v3 resend: added missing to/cc addresses via b4 prep --auto-to-cc.
> 
> Changes since v2:
> - Dropped RFC tag;
> - Reworded @extend_name deprecation comment.
> 
> v2: https://lore.kernel.org/r/20230116220909.196926-1-marijn.suijten@xxxxxxxxxxxxxx
> 
> Changes since v1:
> - qcom-spmi-vadc: Use read_label instead of extend_name.
> 
> New since v1:
> - core: Point users of extend_name field to read_label callback
> - qcom-spmi-adc5: Use datasheet_name string literal for
>   iio_chan_spec::datasheet_name;
> - qcom-spmi-adc5: Fall back to datasheet_name instead of
>   fwnode_get_name() for iio_chan_spec::extend_name (gets rid of @xx in
>   sysfs filenames and labels);
> - qcom-spmi-adc5: Remove unnecessary datasheet_name NULL check.
> 
> v1: https://lore.kernel.org/linux-arm-msm/20221106193018.270106-1-marijn.suijten@xxxxxxxxxxxxxx/
> ---
> Marijn Suijten (5):
>       iio: core: Point users of extend_name field to read_label callback
>       iio: adc: qcom-spmi-adc5: Use driver datasheet_name instead of DT label
>       iio: adc: qcom-spmi-adc5: Fall back to datasheet_name instead of fwnode name
>       iio: adc: qcom-spmi-adc5: Remove unnecessary datasheet_name NULL check
>       iio: adc: qcom-spmi-vadc: Propagate fw node label to userspace
> 
>  drivers/iio/adc/qcom-spmi-adc5.c | 15 +++++++--------
>  drivers/iio/adc/qcom-spmi-vadc.c | 19 ++++++++++++++++++-
>  include/linux/iio/iio.h          |  3 +++
>  3 files changed, 28 insertions(+), 9 deletions(-)
> ---
> base-commit: 92e815cf07ed24ee1c51b122f24ffcf2964b4b13
> change-id: 20230502-iio-adc-propagate-fw-node-label-b1fff2e63ae8