Re: [PATCH] clk: imx: composite-8m: Add imx8m_divider_determine_rate

From: kernel test robot
Date: Sat May 06 2023 - 13:42:30 EST


Hi Adam,

kernel test robot noticed the following build warnings:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on v6.3 next-20230505]
[cannot apply to abelvesa/clk/imx linus/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Adam-Ford/clk-imx-composite-8m-Add-imx8m_divider_determine_rate/20230507-002453
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
patch link: https://lore.kernel.org/r/20230506162403.375212-1-aford173%40gmail.com
patch subject: [PATCH] clk: imx: composite-8m: Add imx8m_divider_determine_rate
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230507/202305070143.iTqgbS75-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/d92df3b38fc20beb735cb3b75f118b45d1ae304b
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Adam-Ford/clk-imx-composite-8m-Add-imx8m_divider_determine_rate/20230507-002453
git checkout d92df3b38fc20beb735cb3b75f118b45d1ae304b
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/clk/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202305070143.iTqgbS75-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/clk/imx/clk-composite-8m.c:122:5: warning: no previous prototype for 'imx8m_divider_determine_rate' [-Wmissing-prototypes]
122 | int imx8m_divider_determine_rate(struct clk_hw *hw,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/imx8m_divider_determine_rate +122 drivers/clk/imx/clk-composite-8m.c

121
> 122 int imx8m_divider_determine_rate(struct clk_hw *hw,
123 struct clk_rate_request *req)
124 {
125 struct clk_divider *divider = to_clk_divider(hw);
126 int prediv_value;
127 int div_value;
128
129 /* if read only, just return current value */
130 if (divider->flags & CLK_DIVIDER_READ_ONLY) {
131 u32 val;
132
133 val = readl(divider->reg);
134 prediv_value = val >> divider->shift;
135 prediv_value &= clk_div_mask(divider->width);
136
137 div_value = val >> PCG_DIV_SHIFT;
138 div_value &= clk_div_mask(PCG_DIV_WIDTH);
139
140 return divider_ro_determine_rate(hw, req, divider->table,
141 PCG_PREDIV_WIDTH + PCG_DIV_WIDTH,
142 divider->flags, prediv_value * div_value);
143 }
144
145 return divider_determine_rate(hw, req, divider->table,
146 PCG_PREDIV_WIDTH + PCG_DIV_WIDTH,
147 divider->flags);
148 }
149

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests