Re: [PATCH v2 1/2] arm64: dts: qcom: Add Fxtec Pro1X (QX1050) DTS

From: Dang Huynh
Date: Fri May 05 2023 - 21:42:23 EST


> > + qcom,board-id = <34 0>;
>
> Does the bootloader refuse to boot without these? Some newer
> ones don't need it.
>
> In case they are compulsory, you'll have to add the pro1x to the
> relevant allOf:if:then: block in bindings.
>
Tested, nope.

> > +&usb_dwc3 {
> > + maximum-speed = "high-speed";
>
> Do you know whether the phone supports usb3? Usually if that's
> the case, you will get usb3 in fastboot.
>
> You'll need an actual usb3 cable to check that though, many claim
> that but then don't have the necessary wires connected.
I asked around, they said yes but without anything to test on hand, I'm not
sure.

Should I remove it or something?

Other than that, I've fixed the other issues with the series.

Best regards,
Dang