Re: [RFC PATCH 11/13] netdevice.h: Fix parentheses around macro parameter use

From: Mathieu Desnoyers
Date: Fri May 05 2023 - 14:54:37 EST


On 2023-05-05 14:44, Jakub Kicinski wrote:
On Thu, 4 May 2023 16:05:25 -0400 Mathieu Desnoyers wrote:
Add missing parentheses around macro parameter use in the following
pattern:

- "x - 1" changed for "(x) - 1",
- "x->member" changed for "(x)->member".

to ensure operator precedence behaves as expected.

Remove useless parentheses around macro parameter use in the following
pattern:

- m((x), y) changed for m(x, y), because comma has the lowest operator
precedence, which makes the extra comma useless.

Sure, why not. Can we take it via netdev, tho?
I can't have any dependencies, right?

I'll note your Acked-by in my patch for the next round. When I post without RFC tag it will be ready for merging. There is still some high-level feedback I want to gather on the overall series before I remove the RFC tag.

There are no dependencies, each patch in this series only target a single header, and there are no dependencies across those patches.

Thanks,

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com