RE: [PATCH v6 5/6] Drivers: hv: vmbus: Support TDX guests

[Dexuan Cui]

> From: Michael Kelley (LINUX) <mikelley@xxxxxxxxxxxxx>
> Sent: Friday, May 5, 2023 9:23 AM
> ...
> From: Dexuan Cui <decui@xxxxxxxxxxxxx>
> >
> > Add Hyper-V specific code so that a TDX guest can run on Hyper-V:
> >   No need to use hv_vp_assist_page.
> >   Don't use the unsafe Hyper-V TSC page.
> >   Don't try to use HV_REGISTER_CRASH_CTL.
> >   Don't trust Hyper-V's TLB-flushing hypercalls.
> >   Don't use lazy EOI.
> 
> Nit:  Actually, you overdid the cleanup. :-(  The line in v5 about
> "Share SynIC Event/Message pages" was correct.  It was only the
> part about VMBus Monitor pages that no longer applied.

Sorry, so here we need to add a line after the line "Don't use lazy EOI":
     Share SynIC Event/Message pages with the host.

I suppose the maintainer(s) can help add this line, if possible.

> >
> > Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> > ---
> > ...
> ...
> Commit message nit notwithstanding --
> 
> Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>

Thanks!