Re: [PATCH] phy: mediatek: fix returning garbage

From: Matthias Brugger
Date: Fri May 05 2023 - 11:37:45 EST




On 05/05/2023 11:28, Vinod Koul wrote:
On 14-04-23, 08:22, Tom Rix wrote:
clang reports
drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
'ret' is uninitialized when used here [-Werror,-Wuninitialized]
if (ret)
^~~
ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.

I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable
usage in pll_calc"

Thanks Vinod, that was on my list for today as well. I was a bit puzzled because you took the patch that added it, but I wasn't sure if you would take the fix. How do you want to handle things like this in the future?

Regards,
Matthias