Re: [PATCH] sched/documentation: elaborate on uclamp limitations

From: Jonathan Corbet
Date: Fri May 05 2023 - 11:31:25 EST


Hongyan Xia <hongyan.xia2@xxxxxxx> writes:

> The story in 5.2 about util_avg abruptly jumping from 300 when
> Fmax/Fmin == 3 to 1024 when Fmax/Fmin == 4 hides some details about how
> clock_pelt works behind the scenes. Explicitly mention it to make it
> easier for readers to follow.

So this is a nit, but...

> +Although running at Fmin reduces the rate of rq_clock_pelt() to 1/3 thus
> +accumulates util_sum at 1/3 of the rate at Fmax, the clock period
> +(rq_clock_pelt() now minus previous rq_clock_pelt()) in:
> +
> +::
> +
> + util_sum / clock period = util_avg

This can be written as:

...previous rq_clock_pelt()) in::

util_sum / clock period = util_avg

reducing the markup clutter and making the document a little more
readable.

Thanks,

jon