Re: [PATCH v2 09/18] media: venus: hfi_venus: Fix version checks in venus_halt_axi()

From: Vikash Garodia
Date: Fri May 05 2023 - 11:29:38 EST


On 5/5/2023 8:13 PM, Dmitry Baryshkov wrote:
On Fri, 5 May 2023 at 16:22, Vikash Garodia <quic_vgarodia@xxxxxxxxxxx> wrote:

On 5/4/2023 1:31 PM, Konrad Dybcio wrote:
Only IRIS2(_1) should enter the until-now-IS_V6() path and the
condition for skipping part of it should be IS_IRIS2_1 and not the
number of VPP pipes. Fix that.
Do not see any issue with existing code. IRIS2 with single pipe is
IRIS2_1. This does not

quality as a fix to earlier implementation. Since this series introduces
VPU versions,

IRIS2 with 1 pipe is being replaced with IRIS2_1.
Could you please fix the line wrapping of your emails. It becomes hard
to read them otherwise.

My apologies for the inconvenience. Tried to set the email wrap config, but it does not take

an effect on my email client. Will try playing around a bit with it and fix it.

Meanwhile go through the comments and if you can align them with minimal effort, we

can continue to discuss on the same.

-Vikash