Re: [PATCH v2] wifi: mt7601u: delete dead code checking debugfs returns

From: Kalle Valo
Date: Fri May 05 2023 - 08:03:25 EST


Wang Jikai <wangjikai@xxxxxxxxxxx> wrote:

> Smatch reports that:
> drivers/net/wireless/mediatek/mt7601u/debugfs.c:130
> mt7601u_init_debugfs() warn: 'dir' is an error pointer or valid".
>
> Debugfs code is not supposed to need error checking so instead of
> changing this to if (IS_ERR()) the correct thing is to just delete
> the dead code.
>
> Signed-off-by: Wang Jikai <wangjikai@xxxxxxxxxxx>
> Acked-by: Jakub Kicinski <kuba@xxxxxxxxxx>

Patch applied to wireless-next.git, thanks.

f3dc7bb037d8 wifi: mt7601u: delete dead code checking debugfs returns

--
https://patchwork.kernel.org/project/linux-wireless/patch/20230421092200.24456-1-wangjikai@xxxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches