Re: [PATCH V5 1/2] arm64: dts: ti: k3-j721s2: fix wkup pinmux range

From: Sinthu Raja M
Date: Fri May 05 2023 - 05:25:13 EST


On Thu, May 4, 2023 at 5:25 PM Nishanth Menon <nm@xxxxxx> wrote:
>
> minor comment: $subject: s/fix/Fix - Vignesh might fix it up prior to
> picking up the series.. but anyways.. just making a side note.
>
> On 13:04-20230504, Sinthu Raja wrote:
> > From: Sinthu Raja <sinthu.raja@xxxxxx>
> >
> > The WKUP_PADCONFIG register region in J721S2 has multiple non-addressable
> > regions, accordingly split the existing wkup_pmx region as follows to avoid
> > the non-addressable regions and include the rest of valid WKUP_PADCONFIG
> > registers. Also update references to old nodes with new ones.
> >
> > wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12)
> > wkup_pmx1 -> 11 pins (WKUP_PADCONFIG 14 - 24)
> > wkup_pmx2 -> 72 pins (WKUP_PADCONFIG 26 - 97)
> > wkup_pmx3 -> 1 pin (WKUP_PADCONFIG 100)
> >
> > Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
> > Signed-off-by: Thejasvi Konduru <t-konduru@xxxxxx>
> > Signed-off-by: Sinthu Raja <sinthu.raja@xxxxxx>
> > ---
>
> is this mcu only ?
Yes, the change is required only for MCU.
>
> Could you provide a link to the output of:
> $ cat /sys/kernel/debug/pinctrl/*/pins
>
> Before and after the fixup? gist.github.com or some similar pastebin
> link to the log will suffice.

Link to logs:
Before Fix: https://pastebin.com/ufseNg8U
After Fix: https://pastebin.com/ABWZ5F4G

>
> [..]
>
>
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D



--
With Regards
Sinthu Raja