Re: [PATCH v3 3/3] arm64: dts: qcom: qrb4210-rb2: Enable aDSP and cDSP remoteproc nodes

[Dmitry Baryshkov]

On Fri, 5 May 2023 at 10:58, Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> wrote:
>
> Enable the aDSP and cDSP remoteproc nodes on Qualcomm QRB4210 RB2 board.
>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index abea44fd369d..3e8ace0ceebc 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -34,6 +34,18 @@ &qupv3_id_0 {
>         status = "okay";
>  };
>
> +&remoteproc_adsp {
> +       firmware-name = "qcom/qrb4210-rb2/adsp.mbn";

Please follow the established practice of firmware names. As the
firmware is not signed by the device vendor and is generic, this
should go to "qcom/qrb4210/adsp.mbn". Same applies to the rest of
firmware paths.

> +
> +       status = "okay";
> +};
> +
> +&remoteproc_cdsp {
> +       firmware-name = "qcom/qrb4210-rb2/cdsp.mbn";
> +
> +       status = "okay";
> +};
> +
>  &rpm_requests {
>         regulators {
>                 compatible = "qcom,rpm-pm6125-regulators";
> --
> 2.38.1
>


-- 
With best wishes
Dmitry