Re: [PATCH V2] arm64: dts: add support for C3 based Amlogic AW409

[xianwei.zhao]

On 2023/5/5 14:34, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 05/05/2023 04:37, xianwei.zhao wrote:
> > Hi Krzysztof,
> >        Thank you for your reply.
> >
> > On 2023/5/1 17:58, Krzysztof Kozlowski wrote:
> > > [你通常不会收到来自 krzysztof.kozlowski@xxxxxxxxxx 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要;]
> > >
> > > [ EXTERNAL EMAIL ]
> > >
> > > On 27/04/2023 10:58, Xianwei Zhao wrote:
> > > > Amlogic C3 is an advanced edge AI processor designed for smart IP camera
> > > > applications.
> > > >
> > > > Add basic support for the C3 based Amlogic AW409 board, which describes
> > > > the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
> > > > booting up into the serial console.
> > > >
> > > > Signed-off-by: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx>
> > > >
> > > > ---
> > > > V1 -> V2: Remove new arch, and use ARCH_MESON;
> > > >             Modify node name, and delete superfluous blank lines.
> > > > ---
> > > >    arch/arm64/boot/dts/amlogic/Makefile          |  1 +
> > > >    .../amlogic/amlogic-c3-c302x-aw409-256m.dts   | 29 +++++++
> > > >    arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi   | 86 +++++++++++++++++++
> > > >    3 files changed, 116 insertions(+)
> > > >    create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
> > > >    create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> > > >
> > > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> > > > index cd1c5b04890a..bcec872c2444 100644
> > > > --- a/arch/arm64/boot/dts/amlogic/Makefile
> > > > +++ b/arch/arm64/boot/dts/amlogic/Makefile
> > > > @@ -74,3 +74,4 @@ dtb-$(CONFIG_ARCH_MESON) += meson-sm1-odroid-hc4.dtb
> > > >    dtb-$(CONFIG_ARCH_MESON) += meson-sm1-sei610.dtb
> > > >    dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air-gbit.dtb
> > > >    dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air.dtb
> > > > +dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409-256m.dtb
> > >
> > > Looks wrongly ordered. 'a' is before 'm'.
> > Will do.
> > > > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
> > > > new file mode 100644
> > > > index 000000000000..edce8850b338
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
> > > > @@ -0,0 +1,29 @@
> > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > +/*
> > > > + * Copyright (c) 2021 Amlogic, Inc. All rights reserved.
> > > > + */
> > > > +
> > > > +/dts-v1/;
> > > > +
> > > > +#include "amlogic-c3.dtsi"
> > > > +
> > > > +/ {
> > > > +     model = "Amlogic C302 aw409 Development Board";
> > > > +     compatible = "amlogic,aw409", "amlogic,c3";
> > >
> > > Missing bindings.
> > >
> > > Please run scripts/checkpatch.pl and fix reported warnings.
> > The bindings committed by Neil, it is applied to
> > https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
> > (v6.5/arm64-dt),
> > bindings:
> > https://lore.kernel.org/all/20230407102704.1055152-1-kelvin.zhang@xxxxxxxxxxx/
>
> It's not in the next, so please always link them. We expect them always
> together, so if you decide to do otherwise, it's your job now to keep us
> informed. Otherwise how can we know that you sent bindings or you didn't?
Will add link in V3,thanks.
> Best regards,
> Krzysztof