[RFC PATCH 00/13] Fix parentheses around macro parameter use in headers

From: Mathieu Desnoyers
Date: Thu May 04 2023 - 17:01:47 EST


I tried to look at various list and list user headers in the kernel tree
to figure out what the proper parentheses pattern should be around macro
parameter use for new code, and it turns out that the current code base
lacks consistency.

This is not an exhaustive change of all public kernel headers, but at
least it is a start, updating those which are implementing or using
kernel lists.

The basic rules followed here are:

- Use parentheses around arguments which are rvalues, except when those
are expressions between commas "," used as arguments to functions or
other macros, or surrounded by brackets "[]".
- Do not use parentheses around arguments which are lvalues.

For consistency, when a macro argument is used both as an lvalue and as
an rvalue within the macro, use the parentheses rules applying to each
of the context: with parentheses for rvalue, without parentheses for
lvalue.

Mathieu Desnoyers (13):
rcu: rcupdate.h: Fix parentheses around macro parameter use
rculist.h: Fix parentheses around macro pointer parameter use
rculist_nulls.h: Add parentheses around macro pointer parameter use
rculist_bl.h: Fix parentheses around macro pointer parameter use
list.h: Fix parentheses around macro pointer parameter use
list_nulls.h: Fix parentheses around macro pointer parameter use
list_bl.h: Fix parentheses around macro pointer parameter use
llist.h: Fix parentheses around macro pointer parameter use
klist.h: Fix parentheses around macro parameter use
resource_ext.h: Remove useless parentheses around macro parameters
netdevice.h: Fix parentheses around macro parameter use
blk-mq.h: Fix parentheses around macro parameter use
bio.h: Fix parentheses around macro parameter use

include/linux/bio.h | 22 +++++++-------
include/linux/blk-mq.h | 38 ++++++++++++------------
include/linux/klist.h | 8 +++---
include/linux/list.h | 54 +++++++++++++++++------------------
include/linux/list_bl.h | 12 ++++----
include/linux/list_nulls.h | 8 +++---
include/linux/llist.h | 14 ++++-----
include/linux/netdevice.h | 12 ++++----
include/linux/rculist.h | 28 +++++++++---------
include/linux/rculist_bl.h | 6 ++--
include/linux/rculist_nulls.h | 4 +--
include/linux/rcupdate.h | 46 ++++++++++++++---------------
include/linux/resource_ext.h | 6 ++--
13 files changed, 129 insertions(+), 129 deletions(-)

--
2.25.1