Re: [PATCH 7/7] dt-bindings: dmaengine: pl330: Add new quirks

[Krzysztof Kozlowski]

On 04/05/2023 16:57, Joy Chakraborty wrote:
> Add 2 new quirks added to the driver "arm,pl330-optimize-dev2mem-axsize"
> and "arm,pl330-periph-single-dregs"

This we can see from the diff. You need to answer why?

> 
> Signed-off-by: Joy Chakraborty <joychakr@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/dma/arm,pl330.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/arm,pl330.yaml b/Documentation/devicetree/bindings/dma/arm,pl330.yaml
> index 4a3dd6f5309b..0499a7fba88d 100644
> --- a/Documentation/devicetree/bindings/dma/arm,pl330.yaml
> +++ b/Documentation/devicetree/bindings/dma/arm,pl330.yaml
> @@ -53,6 +53,14 @@ properties:
>      type: boolean
>      description: quirk for performing burst transfer only
>  
> +  arm,pl330-optimize-dev2mem-axsize:
> +    type: boolean
> +    description: quirk for optimizing AxSize used between dev<->mem

This tells me nothing... Neither what it is about nor why this is
property of a board or PL330 hardware implementation. Please describe
hardware, not drivers.

> +
> +  arm,pl330-periph-single-dregs:
> +    type: boolean
> +    description: quirk for using dma-singles for peripherals in _dregs()

Same concerns.


Best regards,
Krzysztof