Re: [EXTERNAL] Re: [PATCH v1 3/5] firmware: tasdevice_fmw: tasdevice firmware loading lib

From: Mark Brown
Date: Thu May 04 2023 - 10:02:26 EST


On Thu, May 04, 2023 at 01:55:21PM +0000, Ding, Shenghao wrote:

> In fact, we have a dilemma whether to put the code into firmware folder or sound/soc/codecs.
> As you know, most cases are audio-related application, such as a pure audio device or
> audio2haptics device, keeping the tasdevice-firmware lib into sound/soc/codecs would make sense.
> However, in other cases, tasdevice(such as tas2781) can be used as pure haptic to drive the Motor.
> moving the lib into firmware folder would make sense, although such an application is a niche.
> Would you be so kind and give some comments on it? Thanks.

That sounds similar to the other examples where you've got some
non-audio applications and keeping things in firmware as you've done
makes sense. If you resend then mentioning this in the commit message
would be helpful.

Attachment: signature.asc
Description: PGP signature