On Fri 2023-04-28 08:56:59, Rasmus Villemoes wrote:
On 27/04/2023 13.51, Konrad Gräfe wrote:
The CDC-ECM specification requires an USB gadget to send the host MAC
address as uppercase hex string. This change adds the appropriate
modifier.
Thinking more about it, I'm not sure this is appropriate, not for a
single user like this. vsprintf() should not and cannot satisfy all
possible string formatting requirements for the whole kernel. The %pX
extensions are convenient for use with printk() and friends where one
needs what in other languages would be "string interpolation" (because
then the caller doesn't need to deal with temporary stack buffers and
pass them as %s arguments), but for single items like this, snprintf()
is not necessarily the right tool for the job.
In this case, the caller can just as well call string_upper() on the
result
I tend to agree with Rasmus. string_upper() is a super-easy solution.
One user does not look worth adding all the churn into vsprintf().
Best Regards,
Petr
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature