Re: [BISECTED REGRESSION] OMAP1 GPIO breakage

From: Andreas Kemnade
Date: Thu May 04 2023 - 08:45:45 EST


Hi,

On Thu, 4 May 2023 14:13:32 +0200
Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> On Thu, May 4, 2023 at 7:52 AM Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> > * Tony Lindgren <tony@xxxxxxxxxxx> [230426 07:20]:
> > > Seems that we should just revert this patch for now and try again after
> > > the issues have been fixed.
> >
> > Looking at the proposed fixes being posted seems like they are quite
> > intrusive.. How about we partially revert this patch so omap1 still
> > uses static assigment of gpios?
>
> I think Andreas patch (commit 92bf78b33b0b463b00c6b0203b49aea845daecc8)
> kind of describes the problem with that: the probe order is now unpredictable,
> so if we revert the patch then that problem returns, but I don't know how
> serious that problem is.
>
well, I think we can even fully revert 92bf78b33b0b463b00c6b0203b49aea845daecc8
after my patch

gpiolib: fix allocation of mixed dynamic/static GPIOs

is in as a short time solution. That should only leave unpredictable
numbers of multiple dynamic gpio controllers.

Regards,
Andrea