Re: [PATCH RFC 06/16] block: Limit atomic writes according to bio and queue limits

From: John Garry
Date: Thu May 04 2023 - 04:28:53 EST


On 03/05/2023 19:53, Keith Busch wrote:
On Wed, May 03, 2023 at 06:38:11PM +0000, John Garry wrote:
+ unsigned int size = (atomic_write_max_segments - 1) *
+ (PAGE_SIZE / SECTOR_SIZE);
Maybe use PAGE_SECTORS instead of recalculating it.

ok, that simplifies it a bit, but I still do have a doubt that the calc I use for guaranteed amount of data which can fit in a bio without ever requiring splitting to queue limits is correct...

Thanks,
John