Re: [PATCH] sound: caiaq: input: Add error handling for unsupported input methods in `snd_usb_caiaq_input_init`

[Takashi Iwai]

On Thu, 04 May 2023 08:50:53 +0200,
Ruliang Lin wrote:
> 
> Smatch complains that:
> snd_usb_caiaq_input_init() warn: missing error code 'ret'
> 
> This patch adds a new case to handle the situation where the 
> device does not support any input methods in the 
> `snd_usb_caiaq_input_init` function. It returns an `-EINVAL` error code 
> to indicate that no input methods are supported on the device.
> 
> Fixes: 523f1dce3743 ("[ALSA] Add Native Instrument usb audio device support")
> Signed-off-by: Ruliang Lin <u202112092@xxxxxxxxxxx>
> Reviewed-by: Dongliang Mu <dzm91@xxxxxxxxxxx>
> ---
> The issue is found by static analyzer. The patched code has passed
> Smatch checker, but remains untested on real device.

Thanks, applied.


Takashi