Re: [PATCH 1/2] dt-bindings: phy: imx8mq-usb: add phy tuning properties

From: Johannes Zink
Date: Thu May 04 2023 - 03:32:38 EST


Hi Rob, hi Krzysztof,

[snip]
> gentle ping - any opinions on this? Shall I just send a V2 along the lines of the phy-stm32-usbphy.c?

This would be something like (example for the trim-hs-current, taken from pyh-stm32-usbphyc):

st,trim-hs-current:
description: |
Controls HS driver current trimming for choke compensation
- <0> = 18.87 mA target current / nominal + 0%
- <1> = 19.165 mA target current / nominal + 1.56%
- <2> = 19.46 mA target current / nominal + 3.12%
- <3> = 19.755 mA target current / nominal + 4.68%
- <4> = 20.05 mA target current / nominal + 6.24%
- <5> = 20.345 mA target current / nominal + 7.8%
- <6> = 20.64 mA target current / nominal + 9.36%
- <7> = 20.935 mA target current / nominal + 10.92%
- <8> = 21.23 mA target current / nominal + 12.48%
- <9> = 21.525 mA target current / nominal + 14.04%
- <10> = 21.82 mA target current / nominal + 15.6%
- <11> = 22.115 mA target current / nominal + 17.16%
- <12> = 22.458 mA target current / nominal + 19.01%
- <13> = 22.755 mA target current / nominal + 20.58%
- <14> = 23.052 mA target current / nominal + 22.16%
- <15> = 23.348 mA target current / nominal + 23.73%
$ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 15
default: 0

If you think something along these lines is acceptable, I would like to prepare and send a V2.

Best regards
Johannes

[snip]