Re: [PATCH] dt-bindings: usb: Add binding for Microchip usb5744 hub controller

[Michal Simek]

On 5/4/23 08:46, Krzysztof Kozlowski wrote:
> On 03/05/2023 15:39, Michal Simek wrote:
> > The Microchip usb5744 is a SS/HS USB 3.0 hub controller with 4 ports.
> > The binding describes USB related aspects of the USB5744 hub, it as
> > well cover the option of connecting the controller as an i2c slave.
> > When i2c interface is connected hub needs to be initialized first.
> > Hub itself has fixed i2c address 0x2D but hardcoding address is not good
> > idea because address can be shifted by i2c address translator in the
> > middle.
> >
> > Signed-off-by: Piyush Mehta <piyush.mehta@xxxxxxx>
> > Signed-off-by: Michal Simek <michal.simek@xxxxxxx>
> > ---
> >
> > It looks like that usb8041 has also an optional i2c interface which is not
> > covered. But it is mentioned at commit 40e58a8a7ca6 ("dt-bindings: usb:
> > Add binding for TI USB8041 hub controller").
> >
> > i2c-bus name property was suggested by Rob at
> > https://lore.kernel.org/all/CAL_JsqJedhX6typpUKbnzV7CLK6UZVjq3CyG9iY_j5DLPqvVdw@xxxxxxxxxxxxxx/
> > and
> > https://lore.kernel.org/all/CAL_JsqJZBbu+UXqUNdZwg-uv0PAsNg55026PTwhKr5wQtxCjVQ@xxxxxxxxxxxxxx/
> >
> > the question is if adding address like this is acceptable.
> > But it must be specified.
>
> Why? phandle points it explicitly.

Ok it means just list usb hub on i2c with label and point to it. Works for me.

Thanks,
Michal