Re: [PATCH v3 3/3] regulator: axp20x: Add AXP15060 support

From: Krzysztof Kozlowski
Date: Thu May 04 2023 - 03:02:51 EST


On 21/04/2023 17:08, Shengyu Qu wrote:
> The AXP15060 is a typical I2C-controlled PMIC, seen on multiple boards
> with different default register value. Current driver is tested on
> Starfive Visionfive 2.
>
> The RTCLDO is fixed, and cannot even be turned on or off. On top of
> that, its voltage is customisable (either 1.8V or 3.3V). We pretend it's
> a fixed 1.8V regulator since other AXP driver also do like this. Also,
> BSP code ignores this regulator and it's not used according to VF2
> schematic.
>
> Describe the AXP15060's voltage settings and switch registers, how the
> voltages are encoded, and connect this to the MFD device via its
> regulator ID.
>
> ---
> Changes since v2:
> - Rebase to AXP313a series v10 [1] + newest (20230420) -next branch
> - Fix some whitespace (Andre Przywara)
> - Rename swout to sw to keep up with bindings (Andre Przywara)
> - Add check for setting DC-DC frequency (Andre Przywara)
>
> Changes since v1:
> - Nothing
>
> [1] https://lore.kernel.org/linux-sunxi/20230401001850.4988-1-andre.przywara@xxxxxxx/
>
> Signed-off-by: Shengyu Qu <wiagn233@xxxxxxxxxxx>

This was not applied, so you can still fix it.

Broken patch trailer / SoB.

Best regards,
Krzysztof