Re: [PATCH V4 1/3] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM

[Souradeep Chowdhury]

On 5/4/2023 3:40 AM, Caleb Connolly wrote:
> On 17/04/2023 16:08, Souradeep Chowdhury wrote:
> > All Qualcomm bootloaders log useful timestamp information related
> > to bootloader stats in the IMEM region. Add the child node within
> > IMEM for the boot stat region containing register address and
> > compatible string.
> >
> > Signed-off-by: Souradeep Chowdhury <quic_schowdhu@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/sram/qcom,imem.yaml        | 22 ++++++++++++++++++++++
> >   1 file changed, 22 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> > index ba694ce..d028bed 100644
> > --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> > +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> > @@ -49,6 +49,28 @@ patternProperties:
> >       $ref: /schemas/remoteproc/qcom,pil-info.yaml#
> >       description: Peripheral image loader relocation region
> >
> > +  "^stats@[0-9a-f]+$":
> > +    type: object
> > +    description:
> > +      Imem region dedicated for storing timestamps related
> > +      information regarding bootstats.
> > +
> > +    additionalProperties: false
> > +
> > +    properties:
> > +      compatible:
> > +        items:
> > +          - enum:
> > +              - qcom,sm8450-bootstats
>
> This region isn't exclusive to sm8450, it exists also on sdm845 and
> presumably other platforms. Is there any need for an SoC specific
> compatible?

Yes SOC specific compatibles are needed for device tree nodes. This has 
been clarified as per prior discussion on this patch series.

https://lore.kernel.org/lkml/e1d53083-82b6-d193-517e-02af281a066a@xxxxxxxxxx/ 


> > +          - const: qcom,imem-bootstats
> > +
> > +      reg:
> > +        maxItems: 1
> > +
> > +    required:
> > +      - compatible
> > +      - reg
> > +
> >   required:
> >     - compatible
> >     - reg
> > --
> > 2.7.4