Re: [PATCH v2 4/5] arm64: dts: mediatek: mt8192: Add thermal nodes and thermal zones

[Nícolas F. R. A. Prado]

On Tue, Apr 25, 2023 at 03:30:51PM +0200, bchihi@xxxxxxxxxxxx wrote:
> From: Balsam CHIHI <bchihi@xxxxxxxxxxxx>
> 
> Add thermal nodes and thermal zones for the mt8192.
> The mt8192 SoC has several hotspots around the CPUs.
> Specify the targeted temperature threshold to apply the mitigation
> and define the associated cooling devices.
> 
> Signed-off-by: Balsam CHIHI <bchihi@xxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/mediatek/mt8192.dtsi | 454 +++++++++++++++++++++++
>  1 file changed, 454 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 87b91c8feaf96..eb2bd94e0ae86 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
[..]
> +			cooling-maps {
> +				map0 {
> +					trip = <&cpu0_alert>;
> +					cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +								<&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +								<&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +								<&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;

Just a nit, but it would be nice to have these aligned (same for others below).

In any case,

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>

Thanks,
Nícolas