Re: [PATCH] nvme: add cond_resched() to nvme_complete_batch()

From: Keith Busch
Date: Wed May 03 2023 - 19:42:30 EST


On Wed, May 03, 2023 at 10:28:53AM -0600, Keith Busch wrote:
> On Tue, May 02, 2023 at 08:54:12PM +0800, jiweisun126@xxxxxxx wrote:
> > According to the above two logs, we can know the nvme_irq() cost too much
> > time, in the above case, about 4.8 second. And we can also know that the
> > main bottlenecks is in the competition for the spin lock pool->lock.
>
> I have a fix that makes pool->lock critical section much shorter and constant
> time. It was staged in mm tree for months, but mysteriously it's missing...

Well this is certainly odd: the commit I'm referring to is in Linus' log, but
the file it modified is not updated. What kind of 'git' madness is this??

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a4de12a032fa6d0670aa0bb43a2bf9f812680d0f

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/mm/dmapool.c