Re: [PATCH 4/5] KVM: x86: WARN if writes to PAT MSR are handled by common KVM code

From: Sean Christopherson
Date: Wed May 03 2023 - 19:38:11 EST


On Wed, May 03, 2023, Kai Huang wrote:
> On Wed, 2023-05-03 at 11:28 -0700, Sean Christopherson wrote:
> > WARN and continue if a write to the PAT MSR reaches kvm_set_msr_common()
> > now that both VMX and SVM handle PAT writes entirely on their own. Keep
> > the case statement with a WARN instead of dropping it entirely to document
> > why KVM's handling of reads and writes isn't symmetrical (reads are still
> > handled by kvm_get_msr_common().
>
> Why not just merge this patch with the next one?

Hmm, good question. IIRC, I originally had the last patch delete the case
statement and so wanted a bisection point, but I agree that having this as a
standalone patch is silly. I'll squash it with patch 5 in v2.

Thanks!