Re: [PATCH v7 5/9] usb: dwc3: core: Refactor PHY logic to support Multiport Controller

[Thinh Nguyen]

On Wed, May 03, 2023, Krishna Kurapati PSSNV wrote:
> 
> 
> On 5/3/2023 3:41 AM, Thinh Nguyen wrote:
> > On Mon, May 01, 2023, Krishna Kurapati wrote:
> > > Currently the DWC3 driver supports only single port controller
> > > which requires at most one HS and one SS PHY.
> > > 
> > > But the DWC3 USB controller can be connected to multiple ports and
> > > each port can have their own PHYs. Each port of the multiport
> > > controller can either be HS+SS capable or HS only capable
> > > Proper quantification of them is required to modify GUSB2PHYCFG
> > > and GUSB3PIPECTL registers appropriately.
> > > 
> > > Add support for detecting, obtaining and configuring phy's supported
> > > by a multiport controller and limit the max number of ports
> > > supported to 4.
> > > 
> > > Signed-off-by: Harsh Agarwal <quic_harshq@xxxxxxxxxxx>
> > > Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
> > 
> > Are you a co-author or only Harsh is the main author of this patch?
> > 
> Harsh began developing this series and pushed the first 3 RFC versions
> (supporting both usb-phy / generic phy frameworks) until maintainers pointed
> out that we only support generic phy changes.
> 
> From then on I took it up and started pushing next versions. I would say
> both of us are primary authors for this patch. But if there has to be only
> one, I would say its Harsh.
> 
> Regards,
> Krishna,
> 

I just want to check to give you proper credit for the patch's
contribution. Since Harsh isn't the only one working on this you're not
simply transporting this change. Perhaps you should add Co-developed-by
tags.

Thanks,
Thinh