Re: [PATCH v2 2/2] cxl/region: Remove else after return statement
From: Verma, Vishal L
Date: Wed May 03 2023 - 13:59:06 EST
On Mon, 2023-05-01 at 07:53 -0700, Dave Jiang wrote:
>
>
> On 4/27/23 6:22 PM, Raghu H wrote:
> > Issue found with checkpatch
> >
> > The else section here is redundant after return statement, removing it.
> > Sanity and correctness is not affected due to this fix.
> >
> > Signed-off-by: Raghu H <raghuhack78@xxxxxxxxx>
>
> Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
>
> > ---
> > drivers/cxl/core/region.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
Looks good,
Reviewed-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> >
> > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> > index f29028148806..a46d6ad9ef0a 100644
> > --- a/drivers/cxl/core/region.c
> > +++ b/drivers/cxl/core/region.c
> > @@ -2666,11 +2666,11 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
> > "Bypassing cpu_cache_invalidate_memregion() for testing!\n");
> > clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
> > return 0;
> > - } else {
> > - dev_err(&cxlr->dev,
> > - "Failed to synchronize CPU cache state\n");
> > - return -ENXIO;
> > }
> > +
> > + dev_err(&cxlr->dev,
> > + "Failed to synchronize CPU cache state\n");
> > + return -ENXIO;
> > }
> >
> > cpu_cache_invalidate_memregion(IORES_DESC_CXL);