Re: [PATCH] arm64: dts: imx8mp-evk: add dual-role usb port1 support

From: Marco Felsch
Date: Wed May 03 2023 - 11:38:39 EST


Hi Andreas, Shawn,

On 23-04-05, Shawn Guo wrote:
> On Mon, Apr 03, 2023 at 11:38:12AM +0200, Andreas Henriksson wrote:
> > Hello Marco Felsch,
> >
> > On Thu, Mar 30, 2023 at 04:38:13PM +0200, Marco Felsch wrote:
> > > Hi,
> > >
> > > On 23-03-27, Andreas Henriksson wrote:
> > [...]
> > > > / {
> > > > gpio-sbu-mux {
> > > > compatible = "gpio-sbu-mux";
> > [...]
> > > I didn't tested it but at the moment I don't see the problem with my
> > > patch.
> >
> > As Jun Li helpfully explained my patch is not correct, so don't bother.
> >
> > I don't have a problem with your patch, was just trying to share
> > what I had done.

Thanks for sharing :)

> > I've since learned that the board I'll be working on will not even have
> > SS, so I will not pursue SBU. I'll most likely use your patches instead
> > as they seem simpler than what I did and should fully meet my needs for
> > an usb port that works in both host and device mode.
> >
> > Not that it matters, but +1 from me on applying your patches.
> > (If people are hesitant to do it because of lack of SS, then maybe
> > that could be adressed by adding a comment setting the expectations?)
>
> Marco,
>
> Could you update the patch to mention a bit about Super-Speed support
> as discussed here?

Yes I will update the patch accordingly.

Regards,
Marco