Re: [PATCH v7 5/9] usb: dwc3: core: Refactor PHY logic to support Multiport Controller

From: Johan Hovold
Date: Wed May 03 2023 - 10:27:36 EST


On Wed, May 03, 2023 at 07:50:57PM +0530, Krishna Kurapati PSSNV wrote:
> On 5/3/2023 4:40 PM, Johan Hovold wrote:
> > On Mon, May 01, 2023 at 08:04:41PM +0530, Krishna Kurapati wrote:
> >> Currently the DWC3 driver supports only single port controller
> >> which requires at most one HS and one SS PHY.
> >>
> >> But the DWC3 USB controller can be connected to multiple ports and
> >> each port can have their own PHYs. Each port of the multiport
> >> controller can either be HS+SS capable or HS only capable
> >> Proper quantification of them is required to modify GUSB2PHYCFG
> >> and GUSB3PIPECTL registers appropriately.
> >>
> >> Add support for detecting, obtaining and configuring phy's supported
> >> by a multiport controller and limit the max number of ports
> >> supported to 4.
> >>
> >> Signed-off-by: Harsh Agarwal <quic_harshq@xxxxxxxxxxx>
> >> Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
> >> ---
> >> drivers/usb/dwc3/core.c | 262 +++++++++++++++++++++++++++++-----------
> >> drivers/usb/dwc3/core.h | 12 +-
> >> drivers/usb/dwc3/drd.c | 13 +-
> >> 3 files changed, 209 insertions(+), 78 deletions(-)
> >
> > Note that this patch no longer applies and you need to rebase the series
> > on mainline (e.g. including commit 1d72fab47656 ("USB: dwc3: refactor
> > phy handling").

> This series is rebased on top of usb-next (on top of the above
> mentioned patch). Probably that is why its not applying on top of
> linux-next.

Indeed it is. Sorry about the noise. Let me go double check why it did
not apply here. Perhaps I'm missing something else from usb-next.

Johan