Re: [PATCH] fs/9p: Remove INET dependency

[Jason Andryuk]

On Tue, May 2, 2023 at 7:31 PM Dominique Martinet
<asmadeus@xxxxxxxxxxxxx> wrote:
>
> Jason Andryuk wrote on Tue, May 02, 2023 at 08:03:15AM -0400:
> > > Good catch.
> > > Could you add depends on INET to NET_9P_FD in net/9p/Kconfig?
> >
> > trans_fd.o builds without INET and without UNIX.  Looks like trying to
> > use either TCP or UNIX sockets would lead to runtime errors, but it
> > also supports generic file descriptors.  That could be useful for
> > someone.   Since it builds, would it be okay to leave this patch
> > unchanged, or do you still want the depends added?  Leaving the patch
> > unchanged provides more flexibility, though the runtime errors may
> > surprise users.  While I built a Xen kernel without INET or UNIX, that
> > is an unusual scenario.  Typically INET and UNIX sockets will be built
> > in anyway even without a depends.
>
> Hmm, good point; the socket interface is common between INET and
> UNIX.. And you're right about the ability to use plain fd as well.
>
> How about 'imply INET'? That will automatically select INET when
> enabled, but allow someone to disable it explicitly.

This sounds good.

Thanks,
Jason